[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-devel] [PATCH] efi: Fix booting failure with UEFI on ARM
From: Shannon Zhao <shannon.zhao@xxxxxxxxxx> Commit 9fd08b4 (efi: split out efi_get_gop()) splits out the codes getting the pointer to GOP as efi_get_gop(), but it doesn't initialize the variable handles and gop to NULL like what the original codes do. This will cause booting failure on ARM while printing below logs: Xen 4.7-unstable (c/s Tue Oct 13 14:40:28 2015 +0100 git:7a92036) EFI loader Synchronous Exception at 0x00000000FECB021C Signed-off-by: Shannon Zhao <shannon.zhao@xxxxxxxxxx> --- xen/common/efi/boot.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c index 29ce66a..d233cef 100644 --- a/xen/common/efi/boot.c +++ b/xen/common/efi/boot.c @@ -636,8 +636,8 @@ static void __init efi_console_set_mode(void) static EFI_GRAPHICS_OUTPUT_PROTOCOL __init *efi_get_gop(void) { EFI_GRAPHICS_OUTPUT_MODE_INFORMATION *mode_info; - EFI_GRAPHICS_OUTPUT_PROTOCOL *gop; - EFI_HANDLE *handles; + EFI_GRAPHICS_OUTPUT_PROTOCOL *gop = NULL; + EFI_HANDLE *handles = NULL; EFI_STATUS status; UINTN info_size, size = 0; static EFI_GUID __initdata gop_guid = EFI_GRAPHICS_OUTPUT_PROTOCOL_GUID; -- 2.0.4 _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |