Re: [Xen-devel] [PATCH v3 2/6] xen: sched: fix locking for insert_vcpu() in credit1 and RTDS

[Meng Xu <xumengpanda@xxxxxxxxx>]

Hi Dario,

2015-11-04 9:12 GMT-05:00 Dario Faggioli <dario.faggioli@xxxxxxxxxx>:

On Mon, 2015-11-02 at 09:45 -0500, Meng Xu wrote:
> > > I guess maybe you forgot to change it in this commit but change
> > > it
> > > the
> > > following commit?
> > >
> > No, this is one of the few thing that changed between v2 and v3.
> >
> > Regards,
> > Dario
>
> Thanks for the explanation! Then the patch looks good to me, at least
> for RTDS scheduler. :-)
>
Thanks for looking at the patch.

Just FTR (and for next time :-D), is the above something that can be
interpreted as a 'Reviewed-by: Meng Xu <xxx>' ? If no (e.g., because
you haven't looking thoroughly enough to feel confident to express it),
then fine, I was just asking.

âThank you very much for explaining this for me. :-)Â

I feel confident about the changes for RTDS scheduler. I'm not so confident about the change in the schedule.c. To be specific, this patch removes insert_vcpu inÂ

schedule_cpu_switch

â() in schedule.c; I'm not so sure if it is ok to insert_vcpu when a domain is moved. (Next time, I will stand out and ask although it may be a stupid question. ;-) )

â

ââSo as to this patch, I will say:

As far

â â

as the RTDS scheduler is concerned: Reviewed-by: Meng Xu <

âmengxu@xxxxxxxxxxxxxâ

>

â

Â

If yes, I encourage you to say it explicitly, to avoid errors and
misjudgements. If you 'only' looked at the patch with the RTDS
scheduler in mind, that is fine too. You can say something like "As far
as the RTDS scheduler is concerned: Reviewed-by: Meng Xu <xxx>". Other
reviewers and committers will take this into account and properly
weight it.

Every akc/review is important, and, if you took the time to look at a
patch, why don't say it in the proper way? :-)

âSure! I will keep this in mind. â

I'm about to send v4 of this series. Feel free (only if you want, of
course!), to chime in in that thread.

âSure. I will try to have a look. :-)â

Â

Â

âThanks,â

âMengâ

-----------
Meng Xu
PhD Student in Computer and Information Science
University of Pennsylvania
http://www.cis.upenn.edu/~mengxu/

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel