[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-devel] [PATCH v3] xl: log an error if libxl_cpupool_destroy() fails
In fact, right now, failing at destroying a cpupool is just not reported to the user in any explicit way. Let's log an error, as it is customary for xl in these cases. Signed-off-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx> Reviewed-by: Juergen Gross <jgross@xxxxxxxx> Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx> --- Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx> Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx> --- Changes from v2: * rebased on top of staging; * fixed Juergen's email address Changes from v1: * avoid changing the return code to EXIT_SUCCESS/FAILURE; that is being taken care of in another series anyway. --- tools/libxl/xl_cmdimpl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index 2756d2f..5469735 100644 --- a/tools/libxl/xl_cmdimpl.c +++ b/tools/libxl/xl_cmdimpl.c @@ -7581,8 +7581,10 @@ int main_cpupooldestroy(int argc, char **argv) return EXIT_FAILURE; } - if (libxl_cpupool_destroy(ctx, poolid)) + if (libxl_cpupool_destroy(ctx, poolid)) { + fprintf(stderr, "Can't destroy cpupool '%s'\n", pool); return EXIT_FAILURE; + } return EXIT_SUCCESS; } _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |