[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v1] xen/serial: Return actual bytes stored in TX FIFO for OMAP

To: Jan Beulich <JBeulich@xxxxxxxx>, Oleksandr Tyshchenko <oleksandr.tyshchenko@xxxxxxxxxxxxxxx>
From: Ian Campbell <ian.campbell@xxxxxxxxxx>
Date: Tue, 3 Nov 2015 16:36:09 +0000
Cc: Julien Grall <julien.grall@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Delivery-date: Tue, 03 Nov 2015 16:37:00 +0000
List-id: Xen developer discussion <xen-devel.lists.xen.org>

On Tue, 2015-10-27 at 10:40 -0600, Jan Beulich wrote:
> > > > On 27.10.15 at 17:32, <oleksandr.tyshchenko@xxxxxxxxxxxxxxx> wrote:
> > And what are you suggesting about the patch? Create a separate OMAP
> > specific header?
> 
> For #define-s used by only a single source file I'd suggest putting
> them into the source file instead of into a (shared) header.

I agree. (Any to be clear, any existing OMAP specific things in 8250,h
should move too).

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

Follow-Ups:
- Re: [Xen-devel] [PATCH v1] xen/serial: Return actual bytes stored in TX FIFO for OMAP
  - From: Oleksandr Tyshchenko

Prev by Date: [Xen-devel] [PATCH v10 4/5] arm64: introduce CONFIG_PARAVIRT, PARAVIRT_TIME_ACCOUNTING and pv_time_ops
Next by Date: [Xen-devel] [distros-debian-snapshot test] 38244: regressions - trouble: broken/fail/pass
Previous by thread: [Xen-devel] [PATCH v10 0/5] xen/arm/arm64: CONFIG_PARAVIRT and stolen ticks accounting
Next by thread: Re: [Xen-devel] [PATCH v1] xen/serial: Return actual bytes stored in TX FIFO for OMAP
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.