[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 1/4] xen/public: arm: Clarify the name of guest handle structures
On Fri, 30 Oct 2015, Julien Grall wrote: > Currently it's hard to know which __guest_handle* is associated to a > guest handle or a guest handle param. > > Rename the types to match the usage. I.e > * __guest_handle is renamed to __guest_handle_param as it's used for > hypercall parameters. > * __guest_handle_64 is renamed to __guest_handle as it's used for > guest handle in structure field stored in memory. > > Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx> Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx> > Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx> > Cc: Jan Beulich <jbeulich@xxxxxxxx> > Cc: Keir Fraser <keir@xxxxxxx> > Cc: Tim Deegan <tim@xxxxxxx> > --- > xen/include/public/arch-arm.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h > index 6322548..35839db 100644 > --- a/xen/include/public/arch-arm.h > +++ b/xen/include/public/arch-arm.h > @@ -171,9 +171,9 @@ > #ifndef __ASSEMBLY__ > #define ___DEFINE_XEN_GUEST_HANDLE(name, type) \ > typedef union { type *p; unsigned long q; } \ > - __guest_handle_ ## name; \ > + __guest_handle_param_ ## name; \ > typedef union { type *p; uint64_aligned_t q; } \ > - __guest_handle_64_ ## name; > + __guest_handle_ ## name; > > /* > * XEN_GUEST_HANDLE represents a guest pointer, when passed as a field > @@ -186,9 +186,9 @@ > ___DEFINE_XEN_GUEST_HANDLE(name, type); \ > ___DEFINE_XEN_GUEST_HANDLE(const_##name, const type) > #define DEFINE_XEN_GUEST_HANDLE(name) __DEFINE_XEN_GUEST_HANDLE(name, name) > -#define __XEN_GUEST_HANDLE(name) __guest_handle_64_ ## name > +#define __XEN_GUEST_HANDLE(name) __guest_handle_ ## name > #define XEN_GUEST_HANDLE(name) __XEN_GUEST_HANDLE(name) > -#define XEN_GUEST_HANDLE_PARAM(name) __guest_handle_ ## name > +#define XEN_GUEST_HANDLE_PARAM(name) __guest_handle_param_ ## name > #define set_xen_guest_handle_raw(hnd, val) \ > do { \ > typeof(&(hnd)) _sxghr_tmp = &(hnd); \ > -- > 2.1.4 > _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |