[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] libxlu: avoid linker warnings
On Thu, 2015-10-29 at 04:05 -0600, Jan Beulich wrote: > Recent ld warns about libxenlight.so's dependency libraries not being > available, which can be easily avoided by not just passing the raw > library name on ld's command line. > In the course of checking how things fit together (I originally > suspected the warning to come from the linking of xl) I also noticed a > stray L in SHLIB_libxenguest, which gets removed at once. Looks like I (unwittingly) fixed this aspect in http://lists.xen.org/archives/html/xen-devel/2015-10/msg02256.html too. I can easily rebase. Since you have a pickier ld than me I wonder if you would mind trying my patch out on top of yours too? > Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx> > --- a/tools/Rules.mk > +++ b/tools/Rules.mk > @@ -40,7 +40,7 @@ SHLIB_libxenctrl = -Wl,-rpath-link=$(XE > > CFLAGS_libxenguest = -I$(XEN_LIBXC)/include $(CFLAGS_xeninclude) > LDLIBS_libxenguest = $(XEN_LIBXC)/libxenguest$(libextension) > -SHLIB_libxenguest = -Wl,-rpath-link=L$(XEN_LIBXC) > +SHLIB_libxenguest = -Wl,-rpath-link=$(XEN_LIBXC) > > CFLAGS_libxenstore = -I$(XEN_XENSTORE)/include $(CFLAGS_xeninclude) > LDLIBS_libxenstore = $(XEN_XENSTORE)/libxenstore$(libextension) > --- a/tools/libxl/Makefile > +++ b/tools/libxl/Makefile > @@ -41,7 +41,7 @@ LDFLAGS += $(PTHREAD_LDFLAGS) > LIBXL_LIBS += $(PTHREAD_LIBS) > LIBXL_LIBS += $(LIBXL_LIBS-y) > > -LIBXLU_LIBS = libxenlight.so > +LIBXLU_LIBS = $(LDLIBS_libxenlight) > > LIBXL_OBJS-y = osdeps.o libxl_paths.o libxl_bootloader.o flexarray.o > ifeq ($(LIBXL_BLKTAP),y) > > > _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |