[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] cpufreq: allow ordinary boolean options to be passed on the command line
On 02/11/15 10:54, Jan Beulich wrote: >>>> On 30.10.15 at 20:22, <andrew.cooper3@xxxxxxxxxx> wrote: >> On 30/10/15 17:49, Jan Beulich wrote: >>> I was quite surprised to find "cpufreq=off" not doing what one would >>> expect it to do. Fix this. >>> >>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> >>> >>> --- a/docs/misc/xen-command-line.markdown >>> +++ b/docs/misc/xen-command-line.markdown >>> @@ -391,11 +391,12 @@ If set, force use of the performance cou >>> available support. >>> >>> ### cpufreq >>> -> `= dom0-kernel | none | >>> xen[,[powersave|performance|ondemand|userspace][,<maxfreq>][,[<minfreq>][,[verbose]]]]` >>> +> `= none | {{ <boolean> | xen } >>> [:[powersave|performance|ondemand|userspace][,<maxfreq>][,[<minfreq>][,[verbose]]]]} >>> | dom0-kernel` >> If I am reading the parsing correctly below, the insertion if ':' is to >> match the previous behaviour? (or have I missed something?) > We've always supported , and : there. I do think that documenting > comma here is bad (since it's also used as the separator between > sub-options), and hence I've taken the opportunity to make this > match other command line options (where we generally use colon > for separation of main and sub-options). Agreed. Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |