Re: [Xen-devel] [PATCH v2 1/5] symbols: prefix static symbols with their source file names

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 26/10/15 11:49, Jan Beulich wrote:
> This requires adjustments to the tool generating the symbol table and
> its as well as nm's invocation.
>
> Note: Not warning about duplicate symbols in the EFI case for now, as
> a binutils bug causes misnamed file name entries to appear in EFI
> binaries' symbol tables when the file name is longer than 18 chars.
> (Not doing so also avoids other duplicates getting printed twice.)
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Should warn_dups become fatal once the patches to fix these...

Duplicate symbol 'memory.c#get_reserved_device_memory' (ffff82d080140183
!= ffff82d080118b5b)
Duplicate symbol 'platform_hypercall.c#__maddr_to_virt'
(ffff82d08023a3a2 != ffff82d080167e66)
Duplicate symbol 'platform_hypercall.c#__virt_to_maddr'
(ffff82d08023a401 != ffff82d080167ec5)
Duplicate symbol 'platform_hypercall.c#cpumask_check' (ffff82d08023a489
!= ffff82d080167f4d)

have been committed, to avoid accidental reintroduction?

I note that even sysv format doesn't appear to provide directory
information, so we still cant distinguish duplicate static symbols in
identically named source files in difference directories, but hopefully
that should be very rare.

Overall, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>,
although I haven’t vetted the symbol.c changes too carefully.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel