Re: [Xen-devel] [PATCH v4 2/5] xl: improve return and exit codes of scheduling related functions

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Oct 27, 2015 at 06:18:55PM +0530, Harmandeep Kaur wrote:
> Turning scheduling related functions exit codes towards using the
> EXIT_[SUCCESS|FAILURE] constants, instead of instead of arbitrary numbers
> or libxl return codes.
>       - for main_*: arbitrary -> EXIT_SUCCESS|EXIT_FAILURE.
>       - for internal fucntion: arbitrary -> 0/1.
> 

I have one thing to complain. See below.

> Signed-off-by: Harmandeep Kaur <write.harmandeep@xxxxxxxxx>
> Reviewed-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> ---
> v3->v4: No changes.
> v2->v3: Reverted removal of 'rc' in sched_domain_output().
> 
>  tools/libxl/xl_cmdimpl.c | 139 
> +++++++++++++++++++++++------------------------
>  1 file changed, 67 insertions(+), 72 deletions(-)
> 
> diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> index 646b281..b101aff 100644
> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c
> @@ -5793,18 +5793,15 @@ int main_sharing(int argc, char **argv)
>  static int sched_domain_get(libxl_scheduler sched, int domid,
>                              libxl_domain_sched_params *scinfo)
>  {
> -    int rc;
> -
> -    rc = libxl_domain_sched_params_get(ctx, domid, scinfo);
> -    if (rc) {
> +    if (libxl_domain_sched_params_get(ctx, domid, scinfo)){

This, and other instances in both patch 2 and 3, violates coding style.
You need to have a space before "{".

Please go through patch 2 and patch 3 to fix all such violations.

After that, you can add my ack to all your patches. I haven't carefully
read through every line of change, but I think Dario's review is sufficient
and thorough. Thanks Dario.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel