Re: [Xen-devel] [PATCHv1 2/2] passthrough: improve locking when iterating over interrupts bound to VMs

[David Vrabel <david.vrabel@xxxxxxxxxx>]

On 27/10/15 12:44, Jan Beulich wrote:
>>>> On 23.10.15 at 13:05, <david.vrabel@xxxxxxxxxx> wrote:
>> radix_tree_gang_lookup() only requires a RCU read lock, not the
>> per-domain event_lock.
> 
> ... when not caring about a consistent snapshot.
> 
>> @@ -678,9 +684,7 @@ void hvm_dpci_msi_eoi(struct domain *d, int vector)
>>      if ( !iommu_enabled || !d->arch.hvm_domain.irq.dpci )
>>         return;
>>  
>> -    spin_lock(&d->event_lock);
>>      pt_pirq_iterate(d, _hvm_dpci_msi_eoi, (void *)(long)vector);
>> -    spin_unlock(&d->event_lock);
>>  }
> 
> How about other callers of pt_pirq_iterate()?

They weren't hot so I didn't look at them.

David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel