Re: [Xen-devel] [PATCH] xen/mm: Improve message in populate physmap when the domain is direct mapped

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 27.10.15 at 12:49, <julien.grall@xxxxxxxxxx> wrote:
> On 27/10/15 11:45, Andrew Cooper wrote:
>> On 27/10/15 11:33, Julien Grall wrote:
>>> --- a/xen/common/memory.c
>>> +++ b/xen/common/memory.c
>>> @@ -141,7 +141,7 @@ static void populate_physmap(struct memop_args *a)
>>>                      {
>>>                          gdprintk(XENLOG_INFO,
>>>                                   "mfn %#"PRI_xen_pfn" doesn't belong to 
>>> the"
>>> -                                 " domain\n", mfn);
>>> +                                 " domain %d\n", mfn, d->domain_id);
>> 
>> This could easily be shortened to "doesn't belong to d%d" which matches
>> our other domain identification.
> 
> I also just noticed that the message is split between 2 lines. IIRC, we
> are trying to avoid that to allow grep working.
> 
> I will resend this patch with:
> 
> gprintk(XENLOG_INFO,
>       "mfn %#"PRI_xen_pfn" doesn't belong to d%d\n",
>       mfn, d->domain_id).
> 
> Can I keep your reviewed-by with that change?

And no need to resend, btw.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel