Re: [Xen-devel] [PATCH v1] xen/serial: Return actual bytes stored in TX FIFO for OMAP

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 27.10.15 at 11:36, <oleksandr.tyshchenko@xxxxxxxxxxxxxxx> wrote:
> --- a/xen/include/xen/8250-uart.h
> +++ b/xen/include/xen/8250-uart.h
> @@ -143,6 +143,15 @@
>  /* Supplementary control register */
>  #define UART_OMAP_SCR     0x10

I think this one is already misplaced here (as is the one in the context
below the change).

> +/* Supplementary status register */
> +#define UART_OMAP_SSR     0x11
> +
> +/* Supplementary status register bitmasks */
> +#define UART_OMAP_SSR_TX_FIFO_FULL_MASK (1 << 0)
> +
> +/* TX FIFO level register */
> +#define UART_OMAP_TXFIFO_LVL   0x1A

Hence, rather than adding more 8250-unrelated things to this
header, I think this needs cleaning up.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel