[Xen-devel] OSSTest nested patch PART2 -- L2 installation failure

["Hu, Robert" <robert.hu@xxxxxxxxx>]

Hi Ians,

Now I get to L2 installation.

Failures:
1. Use of uninitialized value $prefix in pattern match (m//) at 
Osstest/TestSupport.pm line 1596
sub ether_prefix($) {
    my ($ho) = @_;
    my $prefix = get_host_property($ho, 'gen-ether-prefix-base');
    $prefix =~ m/^(\w+:\w+):(\w+):(\w+)$/ or die "$prefix ?";
    my $lhs = $1;
    my $pv = (hex($2)<<8) | (hex($3));
    $pv ^= $mjobdb->gen_ether_offset($ho,$flight);
    $prefix = sprintf "%s:%02x:%02x", $lhs, ($pv>>8)&0xff, $pv&0xff;
    return $prefix;
}

L1 as host seems not having ether-prefix base defined.
Proposed fix:
my $prefix = get_host_property($ho, 'gen-ether-prefix-base') // '$some default 
value'?

2. Use of uninitialized value $meth in split at Osstest/TestSupport.pm line 1068
sub get_host_method_object ($$$) {
    my ($ho, $kind, $meth) = @_;
    my (@meth) = split /\s+/, $meth;
    my $mo;
    eval ("use Osstest::${kind}::$meth[0];".
          "\$mo = Osstest::${kind}::$meth[0]->new(\$ho, \@meth);")
        or die "get_host_method_object $kind $meth $@";
    return $mo;
}

L1 as host seems not have dhcp watch method defined

Proposed fix:
add default value

Your opinions?

Best Regards,
Robert Ho


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel