Re: [Xen-devel] Ping: [PATCH v3] x86/HVM: correct page dirty marking in hvm_map_guest_frame_rw()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 26.10.15 at 16:20, <wei.liu2@xxxxxxxxxx> wrote:
> On Mon, Oct 26, 2015 at 07:09:06AM -0600, Jan Beulich wrote:
>> >>> On 19.10.15 at 16:53, <JBeulich@xxxxxxxx> wrote:
>> > --- a/tools/libxc/xc_sr_save.c
>> > +++ b/tools/libxc/xc_sr_save.c
>> > @@ -537,7 +537,8 @@ static int suspend_and_send_dirty(struct
>> >      if ( xc_shadow_control(
>> >               xch, ctx->domid, XEN_DOMCTL_SHADOW_OP_CLEAN,
>> >               HYPERCALL_BUFFER(dirty_bitmap), ctx->save.p2m_size,
>> > -             NULL, 0, &stats) != ctx->save.p2m_size )
>> > +             NULL, XEN_DOMCTL_SHADOW_LOGDIRTY_FINAL, &stats) !=
>> > +         ctx->save.p2m_size )
>> >      {
>> >          PERROR("Failed to retrieve logdirty bitmap");
>> >          rc = -1;
>> 
>> Tools maintainers, could I please get an ack or otherwise on this
>> adjustment?
>> 
> 
> Er, there seems to be behaviour change that would cause external users
> of xc_shadow_control cease to function properly.

What behavioral change do you see? So far we simply didn't care
about those permanently mapped pages. Now we provide an
option to include them.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel