Re: [Xen-devel] [PATCH v2 3/5] xl: improve return and exit codes of vcpu related functions

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On Sat, 2015-10-24 at 11:01 +0530, Harmandeep Kaur wrote:
> turning vcpu manipulation functions xl exit codes toward using the
> EXIT_[SUCCESS|FAILURE] macros, instead of instead of arbitrary
> numbers
> or libxl return codes.
> 
Again, distch "xl" from the sentence above.

Again, just one small comment:

> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c

> @@ -5508,7 +5506,9 @@ int main_vcpuset(int argc, char **argv)
>          break;
>      }
>  
> -    return vcpuset(find_domain(argv[optind]), argv[optind + 1],
> check_host);
> +    if (vcpuset(find_domain(argv[optind]), argv[optind + 1],
> check_host))
> +        return EXIT_FAILURE;
> +    else return EXIT_SUCCESS;
>
There's no need of this 'else'.

With these things fixed, this patch is:

Reviewed-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>

Thanks and Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel