Re: [Xen-devel] [PATCH 1/3] xl: convert scheduling related return codes to EXIT_[SUCCESS|FAILURE]

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Fri, 2015-10-23 at 10:30 +0200, Dario Faggioli wrote:
> On Fri, 2015-10-23 at 13:18 +0530, Harmandeep Kaur wrote:
> > turning scheduling related functions xl exit codes towards using the
> > EXIT_[SUCCESS|FAILURE] macros, instead of instead of arbitrary
> > numbers
> > or libxl return codes.
> > 
> So, it's probably worth mentioning that this is Harman's "bite size
> contribution" that is required for applying to the Outreachy program.
> 
> Harman, when you send a patch series, as you did here (thanks and good
> job doing it so quickly :-) ), you want to include a 'cover letter'. That
> is an introductory email, often labelled (usually automatically by git
> tools) as patch 0 of the series itself. In it, you give a brief
> explanation of what the series is meant at, and any kind of information
> you think the people reviewing the series should have, but that wouldn't
> fit in the various patches' changelogs, code comments, etc.

In particular in this case I would like to know whether all xl functions
now use EXIT_SUCCESS/FAILURE or if there is still inconsistencies/work to
be done.

I don't see any existing use of of EXIT_* in xl*.

> 
> For instance, in this case, you could have mentioned (among other things)
> that this is your small contribution for the sake of applying to
> Outreachy right in there. :-)
> 
> Thanks and Regards,
> Dario

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel