Re: [Xen-devel] [PATCH] x86/mm: pod: Use the correct memory flags for alloc_domheap_page{, s}

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 22.10.15 at 17:43, <julien.grall@xxxxxxxxxx> wrote:
> @@ -477,7 +477,7 @@ p2m_pod_offline_or_broken_replace(struct page_info *p)
>  
>      free_domheap_page(p);
>  
> -    p = alloc_domheap_page(d, PAGE_ORDER_4K);
> +    p = alloc_domheap_page(d, 0);

I realize that this is the easiest fix, but I think here we instead want
something like

@@ -477,13 +477,14 @@ p2m_pod_offline_or_broken_replace(struct
 {
     struct domain *d;
     struct p2m_domain *p2m;
+    nodeid_t node = phys_to_nid(page_to_maddr(p));
 
     if ( !(d = page_get_owner(p)) || !(p2m = p2m_get_hostp2m(d)) )
         return;
 
     free_domheap_page(p);
 
-    p = alloc_domheap_page(d, PAGE_ORDER_4K);
+    p = alloc_domheap_pages(d, PAGE_ORDER_4K, MEMF_node(node));
     if ( unlikely(!p) )
         return;
 

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel