[Xen-devel] [OSSTEST PATCH] ap-push: Never push an empty revision

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

ap-push should not be used to delete the target branch.

This safety catch will prevent accidentaly deletion of branches if
there is an undetected failure of whatever is generating the revision
to push.

Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
---
 ap-push |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/ap-push b/ap-push
index d2195f2..3011561 100755
--- a/ap-push
+++ b/ap-push
@@ -25,6 +25,10 @@ revision=$2
 . ./cri-common
 select_xenbranch
 
+if [ "x$revision" = x ]; then
+       echo >&2 "NOT pushing empty revision!"; exit 1
+fi
+
 : ${TAG_LINUX2639:=tested/2.6.39.x}
 
 . ./ap-common
-- 
1.7.10.4


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel