Re: [Xen-devel] [PATCH v7 2/3] x86: add domctl cmd to set/get CDP code/data CBM

[Chao Peng <chao.p.peng@xxxxxxxxxxxxxxx>]

On Tue, Oct 13, 2015 at 09:38:58AM -0600, Jan Beulich wrote:
> >>> On 13.10.15 at 10:53, <he.chen@xxxxxxxxxxxxxxx> wrote:
> > @@ -331,19 +357,34 @@ static bool_t psr_check_cbm(unsigned int cbm_len, 
> > uint64_t cbm)
> >  struct cos_cbm_info
> >  {
> >      unsigned int cos;
> > -    uint64_t cbm;
> > +    uint64_t cbm_code;
> > +    uint64_t cbm_data;
> > +    bool_t cdp;
> >  };
> 
> The bool_t field really fits well in the gap between the first and second
> one; I'll take the liberty to adjust this when committing (unless Chao
> comes forward with further comments; otherwise I'm kind of hoping
> for a Reviewed-by-him).

Correct, it can be a optimization and I don't see any problem. So please feel
free to adjust it. Thereby:

Reviewed-by: Chao Peng <chao.p.peng@xxxxxxxxxxxxxxx>

> 
> Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel