Re: [Xen-devel] patch "x86/cpufreq: relocate the driver register function" breaks cpu hot(un)plug

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 12/10/15 14:19, Jan Beulich wrote:
>>>> On 09.10.15 at 22:00, <konrad.wilk@xxxxxxxxxx> wrote:
>> Anyhow it may be due to the fact that cpufreq_register_driver in Xen is now
>> '__init' If you remove that little thing would it work?
> Before adding this annotation I carefully check all callers, and both
> which I could find are themselves __init. Did I overlook any?

I agree that the __init status of the function is correct.

Other than the register_cpu_notifier() change, there is another change
which checks that !driver_data->target == !driver_data->setpolicy which
might be having an unintended side effect.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel