Re: [Xen-devel] [OSSTEST PATCH 18/26] LVM: Break out lv_create

["Hu, Robert" <robert.hu@xxxxxxxxx>]

> -----Original Message-----
> From: Ian Jackson [mailto:ian.jackson@xxxxxxxxxxxxx]
> Sent: Saturday, September 26, 2015 3:15 AM
> To: xen-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Hu, Robert <robert.hu@xxxxxxxxx>; Ian Campbell
> <ian.campbell@xxxxxxxxxx>; Ian Jackson <ian.jackson@xxxxxxxxxxxxx>; Ian
> Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> Subject: [OSSTEST PATCH 18/26] LVM: Break out lv_create
> 
> We are going to want to reuse this.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> ---
> v14: New patch
> ---
>  Osstest/TestSupport.pm |   15 +++++++++++----
>  1 file changed, 11 insertions(+), 4 deletions(-)
> 
> diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
> index ad017a4..2d1db5d 100644
> --- a/Osstest/TestSupport.pm
> +++ b/Osstest/TestSupport.pm
> @@ -62,7 +62,7 @@ BEGIN {
>                        target_install_packages
> target_install_packages_norec
>                        target_jobdir target_extract_jobdistpath_subdir
>                        target_extract_jobdistpath
> -                      lv_dev_mapper target_guest_lv_name
> +                      lv_create lv_dev_mapper target_guest_lv_name
'target_guest_lv_name' seems lacking in my work directory. Would you
double check if it is in production tree? I checked, seems not.
> 
>                        poll_loop tcpconnect await_tcp
>                        contents_make_cpio
> file_simple_write_contents
> @@ -702,6 +702,15 @@ sub poll_loop ($$$&) {
>      logm("$what: ok. (${waited}s)");
>  }
> 
> +sub lv_create ($$$) {
> +    my ($ho, $vg, $lv, $mb) = @_;
> +    my $lvdev = "/dev/$lv/$vg";
> +    target_cmd_root($ho, "lvremove -f $lvdev ||:");
> +    target_cmd_root($ho, "lvcreate -L ${mb}M -n $lv $vg");
> +    target_cmd_root($ho, "dd if=/dev/zero of=$lvdev count=10");
> +    return $lvdev;
> +}
> +
>  sub lv_dev_mapper ($$) {
>      my ($vg,$lv) = @_;
>      $vg =~ s/-/--/g;
> @@ -1685,9 +1694,7 @@ sub prepareguest ($$$$$$) {
> 
>  sub prepareguest_part_lvmdisk ($$$) {
>      my ($ho, $gho, $disk_mb) = @_;
> -    target_cmd_root($ho, "lvremove -f $gho->{Lvdev} ||:");
> -    target_cmd_root($ho, "lvcreate -L ${disk_mb}M -n $gho->{Lv}
> $gho->{Vg}");
> -    target_cmd_root($ho, "dd if=/dev/zero of=$gho->{Lvdev} count=10");
> +    lvm_lv_create($ho, $gho->{Vg}, $gho->{Lv}, $disk_mb);
>  }
> 
>  sub make_vhd ($$$) {
> --
> 1.7.10.4


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel