Re: [Xen-devel] [PATCH seabios.git rel-1.7.5] fix release-1.7.5 for gcc5

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 08.10.15 at 21:36, <pryorm09@xxxxxxxxx> wrote:
> Signed-off-by: Mark Pryor <pryorm09@xxxxxxxxx>

Without any description I cannot see what is being fixed here, or why
there are _different_ comment changes on the inclusion of the same
comment. Since I assume that whatever issue there was has been
taken care of upstream, I'd suggest - just like for the other patch - to
instead request inclusion of the respective upstream commit (again
obeying ./MAINTAINERS of the affected Xen branch).

Jan

> ---
>  src/kbd.c   | 6 +++---
>  src/mouse.c | 6 +++---
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/src/kbd.c b/src/kbd.c
> index 33a95a3..fbcecc3 100644
> --- a/src/kbd.c
> +++ b/src/kbd.c
> @@ -11,7 +11,7 @@
>  #include "hw/ps2port.h" // ps2_kbd_command
>  #include "hw/usb-hid.h" // usb_kbd_command
>  #include "output.h" // debug_enter
> -#include "stacks.h" // stack_hop
> +#include "stacks.h" // yield
>  #include "string.h" // memset
>  #include "util.h" // kbd_init
>  
> @@ -117,8 +117,8 @@ static int
>  kbd_command(int command, u8 *param)
>  {
>      if (usb_kbd_active())
> -        return stack_hop(command, (u32)param, usb_kbd_command);
> -    return stack_hop(command, (u32)param, ps2_kbd_command);
> +        return usb_kbd_command(command, param);
> +    return ps2_kbd_command(command, param);
>  }
>  
>  // read keyboard input
> diff --git a/src/mouse.c b/src/mouse.c
> index 92ae921..100255d 100644
> --- a/src/mouse.c
> +++ b/src/mouse.c
> @@ -10,7 +10,7 @@
>  #include "hw/ps2port.h" // ps2_mouse_command
>  #include "hw/usb-hid.h" // usb_mouse_command
>  #include "output.h" // dprintf
> -#include "stacks.h" // stack_hop
> +#include "stacks.h" // stack_hop_back
>  #include "util.h" // mouse_init
>  
>  void
> @@ -27,8 +27,8 @@ static int
>  mouse_command(int command, u8 *param)
>  {
>      if (usb_mouse_active())
> -        return stack_hop(command, (u32)param, usb_mouse_command);
> -    return stack_hop(command, (u32)param, ps2_mouse_command);
> +        return usb_mouse_command(command, param);
> +    return ps2_mouse_command(command, param);
>  }
>  
>  #define RET_SUCCESS      0x00
> -- 
> 2.1.4
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx 
> http://lists.xen.org/xen-devel 




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel