Re: [Xen-devel] [PATCH v7 31/32] libxl: allow the creation of HVM domains without a device model.

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Thu, 2015-10-08 at 18:27 +0200, Roger Pau Monnà wrote:
> El 08/10/15 a les 16.36, Ian Campbell ha escrit:
> > On Fri, 2015-10-02 at 17:49 +0200, Roger Pau Monne wrote:
> > > diff --git a/tools/libxl/libxl_types.idl
> > > b/tools/libxl/libxl_types.idl
> > > index d6ef9a2..082fed8 100644
> > > --- a/tools/libxl/libxl_types.idl
> > > +++ b/tools/libxl/libxl_types.idl
> > > @@ -98,6 +98,7 @@ libxl_device_model_version =
> > > Enumeration("device_model_version", [
> > >      (0, "UNKNOWN"),
> > >      (1, "QEMU_XEN_TRADITIONAL"), # Historical qemu-xen device model
> > > (qemu-dm)
> > >      (2, "QEMU_XEN"),             # Upstream based qemu-xen device
> > > model
> > > +    (3, "NONE"),                 # No device model
> > 
> > Is there a #define LIBXL_HAVE_<foo> somewhere in this series somewhere?
> > (Not in this patch I think)
> 
> No, but I'm afraid there should be one indeed. Does:
> 
> #define LIBXL_HAVE_HVM_WITHOUT_DM 1

Usually we would name them after the type or value I think.

So LIBXL_HAVE_DEVICE_MODEL_VERSION_NONE here I think.


> 
> Look reasonable?
> 
> Roger.
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel