Re: [Xen-devel] [PATCH V7 3/7] libxl: add pvusb API

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [PATCH V7 3/7] libxl: add pvusb API"):
> Since this is part of a new "controller" abstraction we do in theory have
> the freedom to do things differently, but it seems to me that having
> something as basic as the list operation differ for devices vs. controller
> would do more harm than good even if the controller interface is strictly
> better. IOW I'm willing to be convinced otherwise but right now I'm pretty
> sure how it is above is the preferable extension to our API.

Hrm.  OK, I guess :-/.

> > > +            tmp = READ_BACKEND(gc, "num-ports");
> > > +            if (!tmp) goto outerr;
> > > +            usbctrl->ports = atoi(tmp);
> > 
> > There are 4 nearly identical stanzas here.  I think a more
> > comprehensive would be helpful.  Maybe a global macro READ_SUBPATH_INT
>                ^MACRO?

Yes.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel