Re: [Xen-devel] [PATCH v7 13/32] xen/vlapic: fixes for HVM code when running without a vlapic

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 02.10.15 at 17:48, <roger.pau@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/hvm/vmx/vmx.c
> +++ b/xen/arch/x86/hvm/vmx/vmx.c
> @@ -2412,7 +2412,8 @@ static void vmx_install_vlapic_mapping(struct vcpu *v)
>  {
>      paddr_t virt_page_ma, apic_page_ma;
>  
> -    if ( !cpu_has_vmx_virtualize_apic_accesses )
> +    if ( !cpu_has_vmx_virtualize_apic_accesses ||
> +         v->domain->arch.hvm_domain.vmx.apic_access_mfn == 0 )
>          return;

Considering that when cpu_has_vmx_virtualize_apic_accesses
this field will always be non-zero by the time we get here, I think
you'd better replace the original condition than amend it.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel