[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] tools: remove unused wrappers for python



On 10/06/2015 01:18 PM, Wei Liu wrote:
On Tue, Oct 06, 2015 at 12:46:08PM +0200, Juergen Gross wrote:
Remove lots of functions in tools/python/xen/lowlevel/xc/xc.c as they
are not used anywhere in the tree. In fact only one function is still
being used from pygrub, namely "xeninfo". All other users seem to have
gone with nuking xm/xend.

Signed-off-by: Juergen Gross <jgross@xxxxxxxx>

Andrew said the python module is useful for debugging purpose. There are
out-of-tree users as well.

I'm not too fussed about either keeping these functions or removing
them. But I would like to leave some time for other people to object.

Do these dead functions affect the work you are doing?

I stumbled over them when looking to make some domain builder data
private to the domain type (here: superpages).

In general I don't like those wrappers very much, as they are not very
maintainable. It's rather easy to miss incrementing a python reference
or to mess up the parameter types and names when calling
PyArg_ParseTupleAndKeywords() (you have to match the kwd_list, the
types of the parameters and the parameters themselves by hand).

BTW: I've been told it's possible to use any shared library from Python,
so there should be no need for a wrapper like this just for debugging
purposes.


Juergen



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.