Re: [Xen-devel] [PATCH OSSTEST v2 3/3] standalone: Make it possible to pass options to run-test

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("[PATCH OSSTEST v2 3/3] standalone: Make it possible to 
pass options to run-test"):
> Currently the remainder of the comnand line is passed after the host=
> ident, which allows for other idents to be given, which isn't all that
> useful in practice.
...
> +     options=
> +     for i in $@ ; do
> +         if [ x$i = x-- ] ; then shift; break ; fi
> +         options="$options $i"
> +         shift
> +     done

Please use an array variable so that it is possible to pass options
containing whitespace etc.  Sorry; I realise this is a very marginal
use case but it's definitely a good idea not to paint oneself into a
corner about this kind of thing.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel