Re: [Xen-devel] [PATCH V7 5/7] xl: add pvusb commands

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Thu, 2015-10-01 at 18:02 +0100, George Dunlap wrote:
> On 25/09/15 03:11, Chunyan Liu wrote:
> > Add pvusb commands: usb-ctrl-attach, usb-ctrl-detach, usb-list,
> > usb-attach and usb-detach.
> > 
> > To attach a usb device to guest through pvusb, one could follow
> > following example:
> > 
> >  #xl usb-ctrl-attach test_vm version=1 num_ports=8
> 
> So all the way back in v2 of this series, I suggested making the
> arguments for usb-ctrl-attach and usb-attach mirror the format that is
> found in the config file[1]
> [...]
> [1]
> marc.info/?i=<
> CAFLBxZb1N3_9PVvg-yC8dyVaiySZVRA3H2e8496vHNEfvrm6Zg@xxxxxxxxxxxxxx>

Re: xl usb-ctrl-attach test_vm name=pv-1,type=pv,version=1,ports=8

FWIW I think most of the existing ones allow (but don't require) a slight
difference in the cli version, which is that they allow space spearated
lists as well as command separate, which ends up a bit more natural:

    xl usb-ctrl-attach test_vm name=pv-1 type=pv version=1 ports=8

I also agree that we should try and do something similar here unless there
is a compelling reason we can't.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel