Re: [Xen-devel] [PATCH v2 1/5] libxc: remove allocate member from struct xc_dom_image

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Fri, 2015-10-02 at 07:49 +0200, Juergen Gross wrote:
> The allocate() callback in struct xc_dom_image is never set. Remove it.
> 
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

This breaks the stubdom build:

kexec.c: In function âkexecâ:
kexec.c:221:78: warning: taking address of expression of type âvoidâ
     xen_pfn_t boot_page_mfn = virt_to_mfn(&_boot_page);
                                                                              ^
kexec.c:230:8: error: âstruct xc_dom_imageâ has no member named âallocateâ
     dom->allocate = kexec_allocate;
        ^
kexec.c:318:60: warning: taking address of expression of type âvoidâ
             virt_to_mfn(&_boot_page));
                                                            ^
Makefile:79: recipe for target 
'/local/scratch/ianc/devel/committer-amd64.git/stubdom/grub-x86_64/kexec.o' 
failed

On i386 too.

And in fact that hook looks useful in that context, so either it needs to
stay of stubdom kexec needs changing to work some other way.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel