Re: [Xen-devel] [PATCH OSSTEST v3 3/3] Create a flight to test OpenStack with xen-unstable and libvirt

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Tue, Sep 29, 2015 at 04:49:29PM +0100, Ian Campbell wrote:
> On Mon, 2015-09-28 at 16:56 +0100, Anthony PERARD wrote:
> > diff --git a/cri-common b/cri-common
> > index c874ff9..66d13d1 100644
> > --- a/cri-common
> > +++ b/cri-common
> > @@ -79,6 +79,7 @@ select_xenbranch () {
> >  >  > ovmf)>        >       >       > tree=ovmf;>   > 
> > xenbranch=xen-unstable ;;
> >  >  > distros-*)>   >       > tree=none;>   > xenbranch=xen-unstable ;;
> >  >  > osstest)>     >       > tree=osstest;>        > 
> > xenbranch=xen-unstable ;;
> > +>  > openstack)>   >       > tree=devstack;>       > 
> > xenbranch=xen-unstable ;;
> 
> Is this "devstack" a left over which should have become openstack-nova like
> the others?

Yes, I should change this one as well.

> @@ -621,6 +636,25 @@ test_matrix_do_one () {
> >  
> >    do_pygrub_tests
> >    do_pvgrub_tests
> > +
> > +  job_create_test test-$xenarch$kern-$dom0arch-devstack \
> > +    test-devstack libvirt $xenarch $dom0arch \
> > +    tree_devstack=$TREE_OPENSTACK_DEVSTACK \
> > +    tree_requirements=$TREE_OPENSTACK_REQUIREMENTS \
> > +    tree_keystone=$TREE_OPENSTACK_KEYSTONE \
> > +    tree_glance=$TREE_OPENSTACK_GLANCE \
> > +    tree_cinder=$TREE_OPENSTACK_CINDER \
> > +    tree_nova=$TREE_OPENSTACK_NOVA \
> > +    tree_tempest=$TREE_OPENSTACK_TEMPEST \
> > +    revision_devstack=master \
> > +    revision_requirements=master \
> > +    revision_keystone=master \
> > +    revision_glance=master \
> > +    revision_cinder=master \
> > +    revision_nova=master \
> 
> This one wants to be $REVISION_OPENSTACK_NOVA which comes from the new call
> to determine_revision which you added.

Ok, I'll change that.

> If what you get when you do a bare git clone of $TREE_OPENSTACK_NOVA is not
> master then to support standalone mode you might want
> ${REVISION_OPENSTACK_NOVA:-master} to set the default for non-cr-daily
> -branch callers.

I think the default is master.

Also, I guest I should remove the other revision_* runvar which are not
very usefull right now.

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel