Re: [Xen-devel] [PATCH OSSTEST v3 1/3] ts-openstack-deploy: Deploy OpenStack on a host with devstack

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [PATCH OSSTEST v3 1/3] ts-openstack-deploy: Deploy 
OpenStack on a host with devstack"):
> On Mon, 2015-09-28 at 16:56 +0100, Anthony PERARD wrote:
> > This script installs any necessary packages and clones all of the
> > OpenStack
> > trees which are used by devstack to deploy OpenStack.
> > 
> > Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> 
> This mostly looks good to me. A few comments.
...
> Do these end up causing the built_revision_foo to say "-dirty" or anything
> like that?

I imagine they would.

I think it might be necessary to extend store_vcs_revision to be able
to pass some kind of ignore list, or perhaps to restore the un-edited
files from the stash, or something.

> Maybe not because I don't see any calls to store_vcs_revision, which I
> think we discussed on an earlier revision?

This is indeed needed I think.

Anthony, do you want tests to be subject to bisection ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel