Re: [Xen-devel] [PATCH OSSTEST v3 1/3] ts-openstack-deploy: Deploy OpenStack on a host with devstack

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Tue, Sep 29, 2015 at 04:34:44PM +0100, Ian Campbell wrote:
> On Mon, 2015-09-28 at 16:56 +0100, Anthony PERARD wrote:
> > This script installs any necessary packages and clones all of the
> > OpenStack
> > trees which are used by devstack to deploy OpenStack.
> > 
> > Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> 
> This mostly looks good to me. A few comments.
> 
> > +  # libvirt is already installed, but not as a package, so avoid
> > installation of
> > +  # the libvirt package with devstack
> > +  target_editfile($ho, "$builddir/devstack/files/debs/nova", sub {
> > +      while (<EI>) {
> > +        next if m/.*libvirt.*/;
> > +        print EO or die $!;
> > +      }
> > +  });
> > +  target_editfile($ho, "$builddir/devstack/lib/nova_plugins/functions
> > -libvirt", sub {
> > +      while (<EI>) {
> > +        next if m/install_package.*libvirt.*/;
> > +        print EO or die $!;
> > +      }
> > +  });
> 
> Do these end up causing the built_revision_foo to say "-dirty" or anything
> like that?
> 
> Maybe not because I don't see any calls to store_vcs_revision, which I
> think we discussed on an earlier revision?

I'm only using build_clone() from osstest to clone any git tree. devstack
is not allowed to clone anything (because of ERROR_ON_CLONE=True in its
config file). So I don't need to call store_vcs_revision, and the tree will
not be seen as -dirty from osstest.

> > +  # OpenStack needs access to libvirt from a user.
> > +  target_cmd_root($ho, <<END);
> 
> You could use target_putfilecontents_root_stash for this too I think?

Well, this append things to the config files, and we thought bash HEREDOC was
"the right answer" ( <1437402707.17368.39.camel@xxxxxxxxxx> ).

The next line of the patch is:
> +    cat >> /etc/libvirt/libvirtd.conf <<EOF

Thanks,

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel