Re: [Xen-devel] [OSSTEST PATCH 3/1] ts-hosts-allocate-Executive: Print more info about booking to main log

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Tue, 2015-09-29 at 16:27 +0100, Ian Jackson wrote:
> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> ---
>  Osstest/Executive.pm |   12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/Osstest/Executive.pm b/Osstest/Executive.pm
> index aeb8c25..3475862 100644
> --- a/Osstest/Executive.pm
> +++ b/Osstest/Executive.pm
> @@ -743,9 +743,19 @@ sub alloc_resources {
>           }]);
>  
>           if ($bookinglist && $ok!=-1) {
> +             my %prstart;
> +             foreach my $book (@{ $bookinglist->{Bookings} }) {
> +                 my $pr = $book->{Reso};
> +                 $pr .= " [$book->{Xinfo}]" if defined $book
> ->{Xinfo};
> +                 push @{ $prstart{ $book->{Start }} }, $pr;

                                                   ^ stray space?

> +             }
> +             my $pr = '';
> +             foreach my $start (sort { $a <=> $b } keys %prstart) {
> +                 $pr .= " \@$start @{ $prstart{$start} }";

Even with one reso and its Xinfo this is going to be quite a long line,
isn't it?

I don't think it really matters in the context, so in any case

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> +             }
>               my $jbookings= to_json($bookinglist);
>                  chomp($jbookings);
> -                logm("resource allocation: booking.");
> +                logm("resource allocation: booking$pr.");
>               $debugm->("bookings = ", $jbookings);
>  
>               printf $qserv "book-resources %d\n", length $jbookings

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel