Re: [Xen-devel] [PATCH OSSTEST 3/6] Debian: uboot: Use di_vg_name() and lv_dev_mapper() for root=

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [PATCH OSSTEST 3/6] Debian: uboot: Use di_vg_name() 
and lv_dev_mapper() for root="):
> On Tue, 2015-09-29 at 15:08 +0100, Ian Jackson wrote:
> > Ian Campbell writes ("[PATCH OSSTEST 3/6] Debian: uboot: Use di_vg_name()
> > and lv_dev_mapper() for root="):
> > > root is not a "guest lv", so using target_guest_lv_name is misleading.
> > > 
> > > target_guest_lv_name also fails to properly handle the guest vg name
> > > correctly, which di_vg_name does.
> > 
> > WDYM `the guest vg name' ?  If it's not a guest lv then is it a guest
> > vg ?
> 
> Sorry, I think I meant "the d-i vg name". Specifically the default VG name
> created by D-I changed in Jessie to append "-vg" to the hostname.

Right.

With that one-word change to the commit message:

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

> i.e. under Squeeze and Wheezy a machine foo would end up with /dev/foo/root
> while under Jessie it becomes /dev/foo-vg/root.

Aha.  (You might mention that too in the commit message.)

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel