Re: [Xen-devel] [PATCH v7 2/2] xen/arm: support gzip compressed kernels

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Tue, 29 Sep 2015, Ian Campbell wrote:
> On Wed, 2015-09-23 at 19:31 +0100, Stefano Stabellini wrote:
> > [/...]
> > +
> > +    /* 
> > +     * Need to free pages after output_size here because they won't be
> > +     * freed by discard_initial_modules
> > +     */
> > +    i = (output_size + PAGE_SIZE - 1) >> PAGE_SHIFT;
> 
> You have access to DIV_ROUND_UP here.
> 
> The rest looks good to me.

Are you sure you want to introduce a / operation that can be easily
avoided?

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel