Re: [Xen-devel] [PATCH for Xen 4.6 2/5] tools/libxl: fix socket display error for CMT

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Sep 28, 2015 at 05:06:31PM +0200, Dario Faggioli wrote:
> On Mon, 2015-09-28 at 19:54 +0800, Chao Peng wrote:
> 
> > diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> > index 2706759..c72d3df 100644
> 
> > @@ -8228,9 +8228,9 @@ static void
> > psr_cmt_print_domain_info(libxl_dominfo *dominfo,
> >  
> >  static int psr_cmt_show(libxl_psr_cmt_type type, uint32_t domid)
> >  {
> > -    uint32_t i, socketid, nr_sockets, total_rmid;
> > +    uint32_t i, socketid, total_rmid;
> >      uint32_t l3_cache_size;
> > -    libxl_physinfo info;
> > +    libxl_bitmap socketmap;
> >      int rc, nr_domains;
> >  
> >      if (!libxl_psr_cmt_enabled(ctx)) {
> > @@ -8244,41 +8244,38 @@ static int psr_cmt_show(libxl_psr_cmt_type
> > type, uint32_t domid)
> >          return -1;
> >      }
> >  
> > -    libxl_physinfo_init(&info);
> > -    rc = libxl_get_physinfo(ctx, &info);
> > +    libxl_socket_bitmap_alloc(ctx, &socketmap, 0);
> > +    rc = libxl_socket_bitmap_fill(ctx, &socketmap);
> >
> Shouldn't socketmap be initied with libxl_bitmap_init() before being
> allocated and used?
> 

Yes.

> Not doing so is certainly not an issue, in this case, but AFAIR, we

That's my thought when I first saw this patch.

> always require that for libxl types, don't we?
> 

But let's stick with convention.

Thanks for your careful review.

Wei.

> Regards,
> Dario
> -- 
> <<This happens because I choose it to happen!>> (Raistlin Majere)
> -----------------------------------------------------------------
> Dario Faggioli, Ph.D, http://about.me/dario.faggioli
> Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel