Re: [Xen-devel] [PATCH OSSTEST v2 5/6] ts-openstack-tempest: Run Tempest to check OpenStack

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Tue, Sep 08, 2015 at 02:06:11PM +0100, Ian Campbell wrote:
> On Thu, 2015-08-06 at 18:03 +0100, Anthony PERARD wrote:
> > Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> > ---
> >  sg-run-job           |  1 +
> >  ts-openstack-tempest | 35 +++++++++++++++++++++++++++++++++++
> >  2 files changed, 36 insertions(+)
> >  create mode 100755 ts-openstack-tempest
> > 
> > diff --git a/sg-run-job b/sg-run-job
> > index 5320d62..0b2184b 100755
> > --- a/sg-run-job
> > +++ b/sg-run-job
> > @@ -363,6 +363,7 @@ proc run-job/test-rumpuserxen {} {
> >  proc need-hosts/test-devstack {} { return host }
> >  proc run-job/test-devstack {} {
> >    run-ts . = ts-openstack-devstack
> > +  run-ts . = ts-openstack-tempest
> 
> As before I think you need "host"

OK.

> >  }
> >  
> >  #---------- builds ----------
> > diff --git a/ts-openstack-tempest b/ts-openstack-tempest
> > new file mode 100755
> > index 0000000..2bc07c3
> > --- /dev/null
> > +++ b/ts-openstack-tempest
> > @@ -0,0 +1,35 @@
> > +#!/usr/bin/perl
> > +# This is part of "osstest", an automated testing framework for Xen.
> > +# Copyright (C) 2015 Citrix Inc.
> > +#
> > +# This program is free software: you can redistribute it and/or modify
> > +# it under the terms of the GNU Affero General Public License as
> > published by
> > +# the Free Software Foundation, either version 3 of the License, or
> > +# (at your option) any later version.
> > +#
> > +# This program is distributed in the hope that it will be useful,
> > +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > +# GNU Affero General Public License for more details.
> > +#
> > +# You should have received a copy of the GNU Affero General Public
> > License
> > +# along with this program.  If not, see <http://www.gnu.org/licenses/>.
> > +
> > +use strict qw(vars);
> > +use Osstest;
> > +use Osstest::TestSupport;
> > +use Osstest::BuildSupport;
> > +
> > +tsreadconfig();
> > +our ($ho,$gho) = ts_get_host_guest(@ARGV);
> 
> And here like before just selecthost since you don't use $gho

Yes, I'll use selecthost.

> > +builddirsprops();
> > +
> > +sub tempest() {
> > +  # The regex is the default one + avoid the two tests know to not work
> > +  # which are two variations of test_volume_boot_pattern.
> > +  target_cmd($ho, <<END, 7200);
> > +    $builddir/tempest/run_tempest.sh
> 
> Is $builddir here inherited from the previous script? I'm not sure how that
> works?

I think the genereted $builddir end up been the same as in the previous
script, because it's generated based on the flight name and the job name.
Both script (ts-openstack-devstack-deploy and ts-openstack-tempest) are
part of the same jobs.

> >  -V -- --concurrency=2
> > '(?!.*\\[.*\\bslow\\b.*\\]|.*test_volume_boot_pattern)(^tempest\\.(api|sc
> > enario|thirdparty))'
> 
> I think think ought to at least be in a variable with a comment explaining
> why each one is omitted.

I'll add a comment, and put this in a variable.

> It could go into a runvar, but I'm not too sure about that.

I don't see a good use of the runvar right now. But it could maybe used to
bisect a single Tempest test, if that even possible. Anyway, I don't think
I want to try to use a runvar for that right now.

> > +END
> > +}
> > +
> > +tempest();

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel