Re: [Xen-devel] [PATCH v4 4/4] docs: add document to introduce CDP command

[He Chen <he.chen@xxxxxxxxxxxxxxx>]

On Fri, Sep 25, 2015 at 10:58:58AM +0100, Ian Campbell wrote:
> On Fri, 2015-09-25 at 17:29 +0800, He Chen wrote:
> > On Thu, Sep 24, 2015 at 12:22:02PM +0100, Ian Campbell wrote:
> > > On Thu, 2015-09-17 at 17:35 +0800, He Chen wrote:
> > > > Add new CDP options with CAT commands in xl interface man page.
> > > > Add description of CDP in xl-psr.markdown.
> > > 
> > > It would have been fine to include this in the previous patch by the
> > > way.
> > > 
> > 
> > You mean include both xl man page and xl-psr.markdown in the previous
> > patch? Or just only xl man page?
> 
> All of the docs could validly be included with the patch which introduces
> the feature. i.e. you could fold patch #4 into #3 completely.
> 
> You don't have to if you don't want to.
> 

Thanks for your reminding, I will merge patch #3 and #4 in next version.

> > Maybe I make words a little confused here.
> > With CDP enabled, user can specify code cache (or data cache) only, and
> > the other would remain previous value (if no previous value, it would
> > keep as default value).
> 
> The value is just enabled or disabled, so do I understand correctly that
> this is what you can do if cdp is enabled:
> 
>     [now: code cbm=<default>; data cbm=<default>]
> 
>     xl psr-cat-cbm-set -c <domid> 0xdeadbeed
>     [now: code cbm=0xdeadbeef; data cbm=<default>]
> 
>     xl psr-cat-cbm-set -d <domid> 0xf00fb00f
>     [now: code cbm=0xdeadbeef; data cbm=0xf00fb00f]
> 
>     xl psr-cat-cbm-set -c -d <domid> 0xd00dfeed
> 
>     [now: code cbm=0xd00dfeed; data cbm=0xd00dfeed]
> 
>     xl psr-cat-cbm-set <domid> 0xee11ee11
> 
>     [now: code cbm=0xee11ee11; data cbm=0xee11ee11]
> 
> Is that right?

Yes.

> 
> And if cdp is not enabled:
> 
>     [now: cbm=<default>]
> 
>     xl psr-cat-cbm-set -c <domid> 0xdeadbeed
>     *ERRROR*
>     [now: cbm=<default>]
> 
> xl psr-cat-cbm-set -d <domid> 0xf00fb00f
>     *ERRROR*
>     [now: cbm=<default>]
> 

Right above.

> xl psr-cat-cbm-set -c -d <domid> 0xd00dfeed
> 
> *ERRROR*
> [now: cbm=<default>]
> 

In current code, it is valid since -c & -d have the same behaviour as
neither of them.
So, it will not show error, and cbm=0xd00dfeed

What do you think of this? Is it proper to do so?

> xl psr-cat-cbm-set <domid> 0xee11ee11
> 
> [now: cbm=0xee11ee11]
> 

Right.

> > So, I think independently would be fine here.
> 
> If I'm correct in all the above then yes.
> 
> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel