[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 3/4] tools: add tools support for Intel CDP



On 24/09/15 11:57, Ian Campbell wrote:
On Thu, 2015-09-17 at 11:38 +0100, Andrew Cooper wrote:
@@ -320,6 +333,8 @@ int xc_psr_cat_get_l3_info(xc_interface *xch,
uint32_t socket,
      {
          *cos_max = sysctl.u.psr_cat_op.u.l3_info.cos_max;
          *cbm_len = sysctl.u.psr_cat_op.u.l3_info.cbm_len;
+        *cdp_enabled = sysctl.u.psr_cat_op.u.l3_info.flags &
+                       XEN_SYSCTL_PSR_CAT_L3_CDP;
!!(sysctl.u.psr_cat_op.u.l3_info.flags & XEN_SYSCTL_PSR_CAT_L3_CDP);

To turn it into a proper boolean, rather than a just a non-zero integer.
Given that *cdp_endabled is bool type does this not happen automagically?


Hmm - spec says yes. Any assignment of a non-zero integer to a _Bool is will be converted to a 1.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.