Re: [Xen-devel] [PATCH] xen: credit1: fix tickling when it happens from a remote pCPU

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On Thu, 2015-09-24 at 08:44 +0200, Juergen Gross wrote:
> On 09/24/2015 06:31 AM, Dario Faggioli wrote:
> > Signed-off-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> 
> Reviewed-by: Juergen Gross <jgross@xxxxxxxx>
> 
> regardless whether you address my suggestion below or not.

> > --- a/xen/common/sched_credit.c
> > +++ b/xen/common/sched_credit.c
> > @@ -168,14 +168,16 @@ struct csched_pcpu {

> >   #define csched_balance_mask (CSCHED_PCPU(smp_processor_id())
> > ->balance_mask)
> 
> Wouldn't it make sense to get rid of that macro? After your patch it
> is
> used only in csched_runq_steal() which is called with cpu being
> always
> smp_processor_id(). You'd eliminate a possible source of future error
> and avoid multiple evaluation of smp_processor_id().
> 
Right. As said to Jan, I like this. I'll respin the patch with only the
new macro.

Thanks and Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel