Re: [Xen-devel] [OSSTEST PATCH 17/27] mg-show-flight-runvars: Decorate synth runvar names with ~

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2015-09-16 at 14:35 +0100, Ian Jackson wrote:
> Make mg-show-flight-runvars -a append ~ to the names of synth runvars.
> (This is consistent with the new syntax in cs-job-create.)
> 
> We do this by editing $row->[1] (and $colws[1]) so we can avoid
> disturbing the general column format calcuation and printing; this

"calculation"

> means we have to copy $row (because the value in the DB $row is
> readonly).

fetchrow_array instead of fetchrow_arrayref would avoid the copy, at the
expense of removing -> from the usages (or taking the ref yourself).


> We have to check for $synth eq 'f' as well as $synth being boolean
> false, because SQLite's typeless nature (or, to put it another way,
> DBD::SQLite's failure to look at the schema) means that a boolean
> field's value of 'f' or 't' is simply returned as a string to Perl.
> But of course "f" is trueish in Perl.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>

Nonetheless:
    Acked-by: Ian Campbell <    ian.campbell@xxxxxxxxxx    >


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel