Re: [Xen-devel] [PATCH v2 for-4.6] libxl: handle read-only drives with qemu-xen

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

M A Young writes ("Re: [PATCH v2 for-4.6] libxl: handle read-only drives with 
qemu-xen"):
> On Tue, 15 Sep 2015, Stefano Stabellini wrote:
> Is ERROR_INVAL the right error to return? I get
> 
> libxl_dm.c: In function 'libxl__build_device_model_args_new':
> libxl_dm.c:807:28: error: return makes pointer from integer without a cast 
> [-Werror=int-conversion]
>                      return ERROR_INVAL;
>                             ^
> cc1: all warnings being treated as errors

Yikes.

> when I try to build xen with the proposed patch.  NULL is returned when 
> there is a problem in other places in this function.

Clearly not.

Stefano, do you want to respin ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel