Re: [Xen-devel] [PATCH OSSTEST v2 3/4] Add support for selecting resources based on their properties.

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("[PATCH OSSTEST v2 3/4] Add support for selecting 
resources based on their properties."):
> In particular for allocating hosts based on host properties.

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>


> +    die "propname: $prop?" unless propname_check($prop);
...
> +sub propname_check ($) {
> +    # ensure propname is valid and in the canonical WordWordWord form
> +    # (rather than, say, one of the legacy forms described in
> +    # propname_massage).

As a matter of taste, I would have had propname_check throw rather
than making it be a predicate.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel