Re: [Xen-devel] [PATCH] vtd/iommu: correct loglevel when check group divices

["Tian, Kevin" <kevin.tian@xxxxxxxxx>]

> From: Chen, Tiejun
> Sent: Wednesday, September 16, 2015 9:00 AM
> 
> Since commit 3848058e7dd6 (vtd/iommu: permit group devices to
> passthrough in relaxed mode) is introduced, we always print
> message as XENLOG_G_WARNING but its not correct in the case of
> strict mode. So here is making this message depending on the
> specific mode.
> 
> CC: Yang Zhang <yang.z.zhang@xxxxxxxxx>
> CC: Kevin Tian <kevin.tian@xxxxxxxxx>
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Wei Liu <wei.liu2@xxxxxxxxxx>
> Signed-off-by: Tiejun Chen <tiejun.chen@xxxxxxxxx>
> ---
>  xen/drivers/passthrough/vtd/iommu.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/drivers/passthrough/vtd/iommu.c
> b/xen/drivers/passthrough/vtd/iommu.c
> index 7b45bff..53aac18 100644
> --- a/xen/drivers/passthrough/vtd/iommu.c
> +++ b/xen/drivers/passthrough/vtd/iommu.c
> @@ -2314,10 +2314,11 @@ static int intel_iommu_assign_device(
>          {
>              bool_t relaxed = !!(flag & XEN_DOMCTL_DEV_RDM_RELAXED);
> 
> -            printk(XENLOG_G_WARNING VTDPREFIX
> +            printk(XENLOG_GUEST "%s" VTDPREFIX
>                     " It's %s to assign %04x:%02x:%02x.%u"
>                     " with shared RMRR at %"PRIx64" for Dom%d.\n",
>                     relaxed ? "risky" : "disallowed",
> +                   relaxed ? XENLOG_WARNING : XENLOG_ERR,

this line should be before risky/disallowed check.

>                     seg, bus, PCI_SLOT(devfn), PCI_FUNC(devfn),
>                     rmrr->base_address, d->domain_id);
>              if ( !relaxed )
> --
> 1.9.1


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel