Re: [Xen-devel] [PATCH 3/4] x86/mce: Translate passed-in GPA to host machine address

[Haozhong Zhang <haozhong.zhang@xxxxxxxxx>]

On Tue, Sep 15, 2015 at 02:50:27PM +0100, Andrew Cooper wrote:
> On 15/09/15 14:42, Haozhong Zhang wrote:
> >
> >>> +                mfn = mfn_x(get_gfn(d, gpfn, &t));
> >>> +
> >>> +                if (mfn == INVALID_MFN) {
> >>> +                    put_domain(d);
> >>> +                    return x86_mcerr("do_mca inject: illegal MSR value",
> >>> +                                     -EINVAL);
> >> This message should be better distinguishable from the one further
> >> down (or else it's pretty pointless) - perhaps you mean GPFN instead
> >> of MSR?
> >>
> > Yes, I'll change it to "do_mca_inject: illegal GPFN".
> 
> Please always always always write useful error messages.  "illegal GPFN"
> is useless without also stating which value is believed to be invalid.
> 
> Furthermore, per the clarification in c/s e758ed1, "gfn" is the correct
> term to use here.
>

I'll update error messages in this patch to include more detailed
information.

> ~Andrew
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel