Re: [Xen-devel] [PATCH 1/4] libxl: convert to use LOG() macro

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Andrew Cooper writes ("Re: [Xen-devel] [PATCH 1/4] libxl: convert to use LOG() 
macro"):
> There are a number of entries like this where the number of lines could
> be reduced.

Indeed, but that's IMO no reason to block this patch which is a big
improvement.

> > -    if (ret==0 || xcinfo.domain != domid) return ERROR_DOMAIN_NOTFOUND;
> > +    if (ret==0 || xcinfo.domain != domid) {
> > +       GC_FREE;
> > +        return ERROR_DOMAIN_NOTFOUND;
> > +    }
> 
> Alignment.

Well spotted.  Thanks for your careful review.

Wei, you should retain my ack when you fix this.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel