[Xen-devel] [PATCH OSSTEST] cri-common: Refactor select_prevxenbranch to cri-getprevxenbranch

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

This moves it outside any prevailing set -x and reduces the amount of
noise in various logs.

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
---
 cri-common           | 16 +---------------
 cri-getprevxenbranch | 19 +++++++++++++++++++
 2 files changed, 20 insertions(+), 15 deletions(-)
 create mode 100755 cri-getprevxenbranch

diff --git a/cri-common b/cri-common
index 94696ab..2669485 100644
--- a/cri-common
+++ b/cri-common
@@ -61,21 +61,7 @@ repo_tree_rev_fetch_git () {
 }
 
 select_prevxenbranch () {
-       local b
-       local p
-       for b in $(./mg-list-all-branches) ; do # already sorted by version
-               case "$b" in
-               xen*)
-                       if [ "x$b" = "x$xenbranch" ] ; then
-                               break
-                       else
-                               p=$b
-                       fi
-                       ;;
-               *)      ;;
-               esac
-       done
-       prevxenbranch=$p
+       prevxenbranch=`./cri-getprevxenbranch $xenbranch`
 }
 
 select_xenbranch () {
diff --git a/cri-getprevxenbranch b/cri-getprevxenbranch
new file mode 100755
index 0000000..dce52c2
--- /dev/null
+++ b/cri-getprevxenbranch
@@ -0,0 +1,19 @@
+#!/bin/bash
+
+xenbranch=$1
+p=
+
+for b in $(./mg-list-all-branches) ; do # already sorted by version
+    case "$b" in
+       xen*)
+           if [ "x$b" = "x$xenbranch" ] ; then
+               break
+           else
+               p=$b
+           fi
+           ;;
+       *)      ;;
+    esac
+done
+
+echo $p
-- 
2.5.1


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel