Re: [Xen-devel] [OSSTest Nested v12 09/21] Wrapper and use core_dump_setup() for nested host and normal host to setup coredump sysctl

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Robert Ho writes ("[OSSTest Nested v12 09/21] Wrapper and use core_dump_setup() 
for nested host and normal host to setup coredump sysctl"):
> This patch does these 4 things:
> 1. wrapper coredump setup code from original ts-host-install into 
> TestSupport.pm
> 2. replace ts-host-install original code with this wrapper function

You mean
   break coredump setup code into new function `core_dump_setup'

Please break this part (the refactoring - ie points 1,2) out into its
own patch.  You can then say `no functional change' (assuming that's
true).

> 3. in debian-hvm-install, create '/var/core' in hvm host post installation.
> 4. in ts-nested-setup, call this function for l1 host.

Is there some reason why the mkdir isn't done in core_dump_setup ?  I
think it is somewhat illogical that the /var/core should be
(implicitly) used in ts-nested-setup but created in
debian-hvm-install.

Also it should do `mkdir -p' in case the directory already exists
somehow.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel