Re: [Xen-devel] [PATCH OSSTEST v2 4/6] ts-openstack-devstack: Deploy OpenStack on a host

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [PATCH OSSTEST v2 4/6] ts-openstack-devstack: Deploy 
OpenStack on a host"):
> On Thu, 2015-08-06 at 18:03 +0100, Anthony PERARD wrote:
> > This script also install packages needed and clone every OpenStack trees to
> > be use by devstack to deploy OpenStack.
> 
> How about:
> 
> This script installs any necessary packages and clones all of the OpenStack
> trees which are used by devstack to deploy OpenStack

We normally call our scripts

  ts-nounphrase-verb[-adverbs]

AIUI `devstack' is a noun.  Does this script do a build, or an
install, or both ?  It's not quite clear to me but I think both.  If
so then perhaps

  ts-openstack-devstack-deploy

?

> > +tsreadconfig();
> > +our ($ho,$gho) = ts_get_host_guest(@ARGV);
> 
> I don't think you use $gho and sg-run-job doesn't pass one, so I think you
> just need to use selecthost.

Indeed.  Does this script even do anything with guests ?

> > +  my $openstack_git_base = git_massage_url('git://git.openstack.org');
> > [...]
> > +GIT_BASE="$openstack_git_base"
> 
> Does this suggest that it might try and clone anything which it can't find
> (i.e. which wasn't cloned by your list of clones), which would defeat the
> purpose of controlling the trees.

> I think you also need to call store_revision for each tree (including any
> you don't explicitly clone here) at the end to record the actual versions
> which were built.

Yes.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel