Re: [Xen-devel] [PATCH v11 2/3] autoconf: xen: enable explicit preference option for xenstored preference

[George Dunlap <dunlapg@xxxxxxxxx>]

On Wed, Jul 30, 2014 at 5:40 PM, Luis R. Rodriguez
<mcgrof@xxxxxxxxxxxxxxxx> wrote:
> From: "Luis R. Rodriguez" <mcgrof@xxxxxxxx>
>
> As it stands oxenstored will be used by default if ocaml tools are
> found, the init system will also try to use oxenstored first if its
> found otherwise the cxenstored will be used. Lets simplify the init
> script and let users be explicit about the preference through configure.
>
> This adds support to let you be explicit about the xenstored preference,
> you can only use one of these two options:
>
> ./configure --with-xenstored=xenstored
> ./configure --with-xenstored=oxenstored
>
> We continue with the old behaviour and default oxenstored will be used
> but only if you have ocaml dependencies. Since the xenstored preference
> is explicit now and since we require configure substitutions for it we
> make use of the AX_XEN_EXPAND_CONFIG() helpers as otherwise substitution
> for SBINDIR is not propagated from the top level configuration.
>
> All this allows us to simplify the init script to use the configured
> xenstore from the start. We update the sysconfig/default xencommons file
> with the paths for the different options though, this can be used by
> users to override the default xenstored, this follows the old behaviour
> but we now just explicitly provide the full configured paths for users.

You keep saying "this follows the old behaviour", but it doesn't.
Before, if I build oxenstored but put it in a separate package (say,
xen-ocaml), it would run oxenstored if available, and if not run
xenstored.  Now it will only try to run one, and if that's not
available it will fail.  That's less of a feature IMHO.

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel